optimization source code

vaicartana · March 4, 2015 at 1:31 PM

I'm not sure I chose the right forum, but here are the author modification "industrial" ...
I found a wasteful method of obtaining the difference tier in the "calculateRatioFor"

Code

if (b.tier() < a.tier() - 1) {
   	value -= 2 * (a.tier() - b.tier());
 	}
 	if (b.tier() - 3 > a.tier()) {
   	value -= b.tier() - a.tier();
 	}

it can be rewritten as follows:

Code

int tier = a.tier() - b.tier();
if (tier > 1) {
   	value -= 2 * tier;
 	}
 	if ( tier < -3) {
   	value += tier;
 	}

This is small change and the load too small, but I hope the mod will be a little better...

Max Shen · March 4, 2015 at 2:12 PM

Quote from vaicartana

in the "calculateRatioFor"

ic2.core.crop.TileEntityCrop::calculateRatioFor(Cropcard a, Cropcard b)
Line number is 404, as of 2.2.687

psusi · March 5, 2015 at 11:25 PM

I've been wondering for a while now where I can find the source code, preferably with instructions on how to build it? I might try my hand at fixing some things.

SpwnX · March 5, 2015 at 11:40 PM Official Post

IC2 source is closed, by the way.

xbony2 · March 6, 2015 at 12:29 AM

Closed as in Closed Sourced. I know everybody's opened IC2 in JD-GUI before, but it's probably best not to post IC2 code unless you really have to. It's probably better to PM Player if you want to suggest a change to IC2.

Max Shen · March 6, 2015 at 12:34 AM

The closest you can get to the sources are by disassembling or decompiling the developer jar. Personally I disassemble because it is lossless. One example of disassembly is the Class File Editor in Eclipse, if you just try and open an internal class of the IC2 jar from a Forge gradle setup.

Player · March 6, 2015 at 8:41 AM Official Post

That's actually not a significant optimization, the compiler may even do it itself.

I've adopted it anyway to improve readability and fixed the previously broken stat comparison.