BUG: Miner TE code crushed SMP server's map

RawCode · Oct 13th 2011

4 miners in row, crush after some time, no way to recover map without removing miners.

Code

2011-10-13 22:52:38 [SEVERE] Unexpected exception
java.lang.StackOverflowError
 at ja.b(ChunkProviderServer.java:81)
 at eh.c(World.java:248)
 at eh.a(World.java:180)
 at ic2.common.TileEntityMiner.canReachTarget(TileEntityMiner.java:442)
 at ic2.common.TileEntityMiner.canReachTarget(TileEntityMiner.java:472)
 at ic2.common.TileEntityMiner.canReachTarget(TileEntityMiner.java:472)
 at ic2.common.TileEntityMiner.canReachTarget(TileEntityMiner.java:472)
 at ic2.common.TileEntityMiner.canReachTarget(TileEntityMiner.java:472)
 at ic2.common.TileEntityMiner.canReachTarget(TileEntityMiner.java:472)
 at ic2.common.TileEntityMiner.canReachTarget(TileEntityMiner.java:472)
 at ic2.common.TileEntityMiner.canReachTarget(TileEntityMiner.java:472)
 at ic2.common.TileEntityMiner.canReachTarget(TileEntityMiner.java:472)
 at ic2.common.TileEntityMiner.canReachTarget(TileEntityMiner.java:472)
 at ic2.common.TileEntityMiner.canReachTarget(TileEntityMiner.java:472)

Display More

Currently working at temporary solution will provide more info later.

Alblaka · Oct 13th 2011

Interesting... stackoverflow with merely these few calls? Usually a stackoverflow goes over ~100 lines.
Either way, mind providing more intel in regard of the miner setup? OV or OD, exspecially.

RawCode · Oct 13th 2011

Reason: chunk unloading, whatever chunk with active miner unload game will crush on next loading of chunk with miner.

other machines not tested yet.

temporal fix - changing mining pipe block it, this will stop all miners and fix problem.

added:

looks like miner will try to operate BEFORE chunk is loaded, or something like this, related to world.obj blockat function, cos this is only line without isnull protection.

added: i able to reproduce this bug on video (youtube or whatever) or send region file from smp server (IC2 mod only), basic steps:

1) Go away from spawn, it always loaded, 500 blocks is okay.
2) Place miner, diamond drill stack of pipes, OV scaner and set of single use batteries.
3) Wait miner to place few pipes.
4) Leave game.
5) Wait 15 seconds.
6) Join again, server will crush.

one more addition:

same shoud happen to pump, teleporter, terramorfer and reactor and basically to any other machine that scan for blocks in world.

nallar · Oct 13th 2011

Quote from RawCode

Reason: chunk unloading, whatever chunk with active miner unload game will crush on next loading of chunk with miner.

other machines not tested yet.

temporal fix - changing mining pipe block it, this will stop all miners and fix problem.

added:

looks like miner will try to operate BEFORE chunk is loaded, or something like this, related to world.obj blockat function, cos this is only line without isnull protection.

added: i able to reproduce this bug on video (youtube or whatever) or send region file from smp server (IC2 mod only), basic steps:

1) Go away from spawn, it always loaded, 500 blocks is okay.
2) Place miner, diamond drill stack of pipes, OV scaner and set of single use batteries.
3) Wait miner to place few pipes.
4) Leave game.
5) Wait 15 seconds.
6) Join again, server will crush.

one more addition:

same shoud happen to pump, teleporter, terramorfer and reactor and basically to any other machine that scan for blocks in world.

Display More

IF that's the case, since the fix owuldn't be complicated, will there be a patch?

Alblaka · Oct 13th 2011

You DO realise that his "fix" was to "cripple" the miners by manually removing the pipes? That's not exactly something we can provide as a patch.

BrickedKeyboard · Oct 13th 2011

No, but you could add a check in the code for each of those machines to see if the chunk they are trying to access is loaded first, right?

RawCode · Oct 13th 2011

this is not "patch" only method to recover your world to backup it and wait for solution.

second solution is to replace te code for miner with code that does nothing, but i was not able to compile it back.

Alblaka · Oct 14th 2011

Quote from BrickedKeyboard

No, but you could add a check in the code for each of those machines to see if the chunk they are trying to access is loaded first, right?

Ah, you meant that one. Yes, that's possible and the easiest solution.

RawCode · Oct 14th 2011

Basically this need hotfix, ever if you stay near miner, on connection problem or server problem you will get map corruption.

Easy solution try catch block for this expeption, this will force server to continue ever if miner attempt null block.

Also, looks like miner will crush map if hit void, there is no zero height check (or i missed it).

Checked other machines:
Pump - no crush.
Reactor - no crush.
Terramorfer - not cheked.

Share