Trouble getting Forge SRC to work with IC²

Two · Sep 27th 2012

Hi,

I am currently trying to get a bit into the IC² API however I can't even seem to get Forge to load IC² from Eclipse.

Steps I've done so far:
1. Clean MCP install (7.2)
2. Clean Forge src 4.1.1.251 install
3. Copied clean Jars/libs
4. Run Forge install.cmd
5. Started Eclipse, launched the game, everything works fine
6. Copied industrialcraft-2_1.106.jar to jars/mods
7. Launched the game again (from Eclipse), crash:

Display Spoiler

Code

...
2012-09-27 18:49:49 [FINE] [ForgeModLoader] Examining file minecraft.jar for potential mods
2012-09-27 18:49:49 [FINE] [ForgeModLoader] The mod container minecraft.jar appears to be missing an mcmod.info file
2012-09-27 18:49:49 [FINE] [ForgeModLoader] Examining file industrialcraft-2_1.106.jar for potential mods
2012-09-27 18:49:49 [FINER] [ForgeModLoader] Located mcmod.info file in file industrialcraft-2_1.106.jar
2012-09-27 18:49:49 [FINE] [ForgeModLoader] Identified an FMLMod type mod ic2.common.IC2
2012-09-27 18:49:49 [FINEST] [ForgeModLoader] Parsed dependency info : [] [] []
2012-09-27 18:49:49 [INFO] [ForgeModLoader] Forge Mod Loader has identified 3 mods to load
2012-09-27 18:49:49 [FINE] [ForgeModLoader] Received a system property request ''
2012-09-27 18:49:49 [FINE] [ForgeModLoader] System property request managing the state of 0 mods
2012-09-27 18:49:49 [FINE] [ForgeModLoader] After merging, found state information for 0 mods
2012-09-27 18:49:49 [FINE] [ForgeModLoader] Activating mod FML
2012-09-27 18:49:49 [FINE] [ForgeModLoader] Activating mod Forge
2012-09-27 18:49:49 [FINE] [ForgeModLoader] Enabling mod IC2
2012-09-27 18:49:49 [FINE] [ForgeModLoader] Activating mod IC2
2012-09-27 18:49:49 [FINE] [ForgeModLoader] Verifying mod requirements are satisfied
2012-09-27 18:49:49 [FINE] [ForgeModLoader] All mod requirements are satisfied
2012-09-27 18:49:49 [FINE] [ForgeModLoader] Sorting mods into an ordered list
2012-09-27 18:49:49 [FINE] [ForgeModLoader] Mod sorting completed successfully
2012-09-27 18:49:49 [FINE] [ForgeModLoader] Mod sorting data:
2012-09-27 18:49:49 [FINE] [ForgeModLoader] 	IC2(IndustrialCraft 2:1.106): industrialcraft-2_1.106.jar ()
2012-09-27 18:49:49 [FINER] [ForgeModLoader] Posting state event cpw.mods.fml.common.event.FMLConstructionEvent@6ac6724c to mod FML
2012-09-27 18:49:49 [FINER] [ForgeModLoader] State event cpw.mods.fml.common.event.FMLConstructionEvent@6ac6724c delivered to mod FML
2012-09-27 18:49:49 [FINER] [ForgeModLoader] Posting state event cpw.mods.fml.common.event.FMLConstructionEvent@6ac6724c to mod Forge
2012-09-27 18:49:49 [FINER] [ForgeModLoader] State event cpw.mods.fml.common.event.FMLConstructionEvent@6ac6724c delivered to mod Forge
2012-09-27 18:49:49 [FINER] [ForgeModLoader] Posting state event cpw.mods.fml.common.event.FMLConstructionEvent@6ac6724c to mod IC2
2012-09-27 18:49:50 [INFO] [STDOUT] 27 achievements
2012-09-27 18:49:50 [INFO] [STDOUT] 195 recipes
2012-09-27 18:49:50 [FINEST] [ForgeModLoader] Testing mod IC2 to very it can accept it's own version in a remote connection
2012-09-27 18:49:50 [FINEST] [ForgeModLoader] The mod IC2 accepts it's own version (1.106)
2012-09-27 18:49:50 [FINE] [ForgeModLoader] Attempting to inject @SidedProxy classes into IC2
2012-09-27 18:49:50 [INFO] [STDERR] Exception in thread "Minecraft main thread" java.lang.VerifyError: (class: ic2/common/PlatformClient, method: <init> signature: ()V) Incompatible argument to function
2012-09-27 18:49:50 [INFO] [STDERR] 	at java.lang.Class.forName0(Native Method)
2012-09-27 18:49:50 [INFO] [STDERR] 	at java.lang.Class.forName(Unknown Source)
2012-09-27 18:49:50 [INFO] [STDERR] 	at cpw.mods.fml.common.ProxyInjector.inject(ProxyInjector.java:51)
2012-09-27 18:49:50 [INFO] [STDERR] 	at cpw.mods.fml.common.FMLModContainer.constructMod(FMLModContainer.java:348)
2012-09-27 18:49:50 [INFO] [STDERR] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2012-09-27 18:49:50 [INFO] [STDERR] 	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
2012-09-27 18:49:50 [INFO] [STDERR] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
2012-09-27 18:49:50 [INFO] [STDERR] 	at java.lang.reflect.Method.invoke(Unknown Source)
2012-09-27 18:49:50 [INFO] [STDERR] 	at com.google.common.eventbus.EventHandler.handleEvent(EventHandler.java:69)
2012-09-27 18:49:50 [INFO] [STDERR] 	at com.google.common.eventbus.SynchronizedEventHandler.handleEvent(SynchronizedEventHandler.java:45)
2012-09-27 18:49:50 [INFO] [STDERR] 	at com.google.common.eventbus.EventBus.dispatch(EventBus.java:317)
2012-09-27 18:49:50 [INFO] [STDERR] 	at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:300)
2012-09-27 18:49:50 [INFO] [STDERR] 	at com.google.common.eventbus.EventBus.post(EventBus.java:268)
2012-09-27 18:49:50 [INFO] [STDERR] 	at cpw.mods.fml.common.LoadController.propogateStateMessage(LoadController.java:124)
2012-09-27 18:49:50 [INFO] [STDERR] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2012-09-27 18:49:50 [INFO] [STDERR] 	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
2012-09-27 18:49:50 [INFO] [STDERR] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
2012-09-27 18:49:50 [INFO] [STDERR] 	at java.lang.reflect.Method.invoke(Unknown Source)
2012-09-27 18:49:50 [INFO] [STDERR] 	at com.google.common.eventbus.EventHandler.handleEvent(EventHandler.java:69)
2012-09-27 18:49:50 [INFO] [STDERR] 	at com.google.common.eventbus.SynchronizedEventHandler.handleEvent(SynchronizedEventHandler.java:45)
2012-09-27 18:49:50 [INFO] [STDERR] 	at com.google.common.eventbus.EventBus.dispatch(EventBus.java:317)
2012-09-27 18:49:50 [INFO] [STDERR] 	at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:300)
2012-09-27 18:49:50 [INFO] [STDERR] 	at com.google.common.eventbus.EventBus.post(EventBus.java:268)
2012-09-27 18:49:50 [INFO] [STDERR] 	at cpw.mods.fml.common.LoadController.distributeStateMessage(LoadController.java:81)
2012-09-27 18:49:50 [INFO] [STDERR] 	at cpw.mods.fml.common.Loader.loadMods(Loader.java:458)
2012-09-27 18:49:50 [INFO] [STDERR] 	at cpw.mods.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:144)
2012-09-27 18:49:50 [INFO] [STDERR] 	at net.minecraft.client.Minecraft.startGame(Minecraft.java:405)
2012-09-27 18:49:50 [INFO] [STDERR] 	at net.minecraft.client.Minecraft.run(Minecraft.java:737)
2012-09-27 18:49:50 [INFO] [STDERR] 	at java.lang.Thread.run(Unknown Source)
2012-09-27 18:53:53 [INFO] [STDERR] Someone is closing me!

Display More

Any idea what I am doing wrong?

GregoriusT · Sep 27th 2012

I wouldnt use the normal startfunction of MCP to test. I just recompile, reobfuscate, zipfile and modsfolder it, and I'm ready to test.

Two · Sep 27th 2012

Quote from GregoriusT

I wouldnt use the normal startfunction of MCP to test. I just recompile, reobfuscate, zipfile and modsfolder it, and I'm ready to test.

Although that works, that kind of slows down coding by a factor of way-too-much.

F4113nb34st · Sep 29th 2012

reason it's crashing is because the api tries to reference classes that don't exist (the base ic2 ones)

GregoriusT · Sep 29th 2012

The API cant crash, because of missing IC². There are try-catch-Blocks around the API-Functions for that case.

F4113nb34st · Sep 30th 2012

Well, more like your stuff crashes when you reference things like ic2 items, either way, it has the same result

Two · Sep 30th 2012

Thinking about it for a while made things clear: if IC² jar references classes by their obfuscated names, but the src obviously de-obfuscates, so the jar cannot access the Eclipse-compiled code as of the different names of the functions.

That is kind of a downer for IC development, as compiling/re-obfuscating then copying the stuff into the original jar is not only tedious but even if automated takes several seconds to complete and then it is still not debuggable. However to solve this you would need the source code of IC² or at least a non-obfuscated jar to work with.

FenixR · Sep 30th 2012

Yeah but that would beat the purpose of being a "Closed Source" project. You just gotta deal with it or pile up your coding and test when you absolutely must do it, not after every little change.

Two · Oct 1st 2012

Quote from FenixR

Yeah but that would beat the purpose of being a "Closed Source" project. You just gotta deal with it or pile up your coding and test when you absolutely must do it, not after every little change.

Closed Source is a relative term, it took me 15 minutes to decompile the IC² jar to get the complete source-code. Now if I would spend some more time to get it to work with Forge that should do it, however having a downloadable version would make things a lot less painful. Decompiling the "Closed Source" Minecraft by the way only takes about 3 minutes thanks to MCP. What defines closed source is just the license on top of it.

The big question is whether or not the IC team wants modders or just acknowledge the fact that they exist. Since there is an API I guess that they do want them, a logical next step then would be to give out a development version for the sole purpose of being able to use it together with the Eclipse-Forge version. The work here for the team is minimal, as they just need to zip the stuff they have on their hard-disk anyways, and the IMS license still holds true the same way as before.

RawCode · Oct 1st 2012

without MCP development of any mod for minecraft will take long time, without forge or similar framework anything is incompatable with anything.

I suggest you to perform two stage decompilation for better results:

Forge install on clean jar.
Decompilation of live jar.
Copypaste IC2 sources only into clean source.
Update names.
Registed workspace in eclipce.
Work without major issues.

Quote

Although that works, that kind of slows down coding by a factor of way-too-much.

suggest to run code inside your head, this allow to debug ever without running game, this really helps and allow to write code in single run.

Two · Oct 1st 2012

Quote from RawCode

I suggest you to perform two stage decompilation for better results:

This was about what I did except for the update names part, which left me with field23423 parts all over the IC code for vanilla functions. Thanks! Going to try that once I am back home.

Quote from RawCode

suggest to run code inside your head, this allow to debug ever without running game, this really helps and allow to write code in single run.

This only works as long as said compiler knows how functions work, but if you don't know Minecraft code literally out of your head, the simulation might come up with different results.

GregoriusT · Oct 1st 2012

I dont know if thats exactly what RawCode suggested, but i have a second MCP-Environment just for decompiling Mods. Then I take the desired Source out of it, and put it into my Main-MCP-Setup (the one with the Default-Forge-Install).

And for testing, i still strongly suggest running it inside the normal Minecraft-Environment instead of the MCP-one. Also it takes only a Minute (for me, and since your decompiling takes also 15 Minutes, like with mine, that should also apply to your Computer), to recompile and reobfuscate the Code, and then i just zip it and put it into the mods-folder. That way i can find more Bugs, than with the MCP-Environment.

FenixR · Oct 1st 2012

Closed source to me means "You can't have access to the ORIGINAL source we have, period", yes you can decompile IC2 and Minecraft but how many errors that gives you (And in the case of ic2 how many things you lose), you say it only takes you 5-15min to decompile but thats because of MCP and the really helpful tools they provide. Ever tried to decompile minecraft or ic2 without MCP?

Not every "Closed Source" code in this world have their own useful "MCP".

Two · Oct 1st 2012

Quote from FenixR

Closed source to me means "You can't have access to the ORIGINAL source we have, period", yes you can decompile IC2 and Minecraft but how many errors that gives you (And in the case of ic2 how many things you lose), you say it only takes you 5-15min to decompile but thats because of MCP and the really helpful tools they provide. Ever tried to decompile minecraft or ic2 without MCP?

Not every "Closed Source" code in this world have their own useful "MCP".

Closed Source just means that you are not allowed to modify, distribute or publish the source code in any form unless permitted by the author. This is a pure license question and not whether or not you actually have the source code. Even though I was able to decompile the source-code, which is by the way thanks to Java almost exactly the same as the IC team has (so no errors or lost stuff), I still cannot just distribute/publish/release it. There are several projects which work under a closed source license even though the source code can be just downloaded for various purposes.

Yes of course I am using MCP, why wouldn't I? If I had to do it without it might take another 15 minutes to setup the decompiler first. I think you are a little mistaken here on the complexity of doing that with Java code.

Nevertheless it would be still very helpful if the IC team would release a non-obfuscated JAR for the modders out there.

Share