Decoblocks Modding Issues

MrEyeballs29 · Feb 17th 2018

Code

@Override
public float getBlockHardness(World world, int x, int y, int z) {
return this.blockHardness;
}
    
@Override
public float getExplosionResistance(Entity entity) {
   return this.blockResistance;
}


@Override
public float getExplosionResistance(Entity par1Entity, World world, int x, int y, int z, double explosionX,
double explosionY, double explosionZ) {
return this.blockResistance;
}

Display More

I actually overrode them both explosion resistances.

GregoriusT · Feb 17th 2018

Ah good, was not easy to notice. So what now?

MrEyeballs29 · Feb 17th 2018

All I have to do is just make the different hardnesses and blast resistances via metadata and a enum too.

Java

@Override
    public float getBlockHardness(World world, int x, int y, int z) {
    return world.getBlockMetadata(x, y, z) == 0 ? 1.5F : 3.0F;

    }
    
    @Override
    public float getExplosionResistance(Entity entity) {
        return this.blockResistance;
    }


@Override
    public float getExplosionResistance(Entity par1Entity, World world, int x, int y, int z, double explosionX,
    double explosionY, double explosionZ) {
    return world.getBlockMetadata(x, y, z) == 0 ? 1.0F : 2.0F;
}

Display More

GregoriusT · Feb 17th 2018

Yeah dont use an Enum, just use a float[] Array for that.

MrEyeballs29 · Feb 17th 2018

Can you give me an example for an float[] Array from one of your files that contain a different hardness/blast resistance.

GregoriusT · Feb 17th 2018

dude its literally

public static final float[] RESISTANCES = {1.0F, 2.0F, 3.0F, 4.0F, 1.0F, 2.0F, 3.0F, 4.0F, 1.0F, 2.0F, 3.0F, 4.0F, 1.0F, 2.0F, 3.0F, 4.0F};

and then return RESISTANCES[world.getBlockMetadata(x, y, z)];

You REALLY REALLY need to learn Java before modding

MrEyeballs29 · Feb 17th 2018

I know Java a lot but it is just getting the hardness and the resistance is the problem I don't know for those.

Java

public static final float[] RESISTANCES = {1.0F, 2.0F, 3.0F, 4.0F, 1.0F, 2.0F, 3.0F, 4.0F, 1.0F, 2.0F, 3.0F, 4.0F, 1.0F, 2.0F, 3.0F, 4.0F};
    
@Override
public float getBlockHardness(World world, int x, int y, int z) {
    return RESISTANCES[world.getBlockMetadata(x, y, z)] == 0 ? 1.5F : 3.0F;
}

@Override
public float getExplosionResistance(Entity entity) {
    return this.blockResistance;
}

@Override
public float getExplosionResistance(Entity par1Entity, World world, int x, int y, int z, double explosionX,
    double explosionY, double explosionZ) {
    return RESISTANCES[world.getBlockMetadata(x, y, z)] == 0 ? 1.0F : 2.0F;
}

Display More

MrEyeballs29 · Feb 17th 2018

GregoriusT I knew an enum was a bad idea. If you use an enum if the number doesn't exsist then it will 100% crash.

GregoriusT · Feb 17th 2018

Try to always avoid using Enums, its not worth the effort.

MrEyeballs29 · Feb 18th 2018

I am going to delete that enum. Also take a look at this code

Code

@Override
    public float getBlockHardness(World world, int par2, int par3, int par4)
    {
        final int meta = world.getBlockMetadata(par2, par3, par4);
        if (meta != 1) {
            return 1.5F;
        } else if (meta == 1) {
            return 3.0F;
        }
        return this.blockHardness;
    }
    
    @Override
    public float getExplosionResistance(Entity par1Entity, World world, int x, int y, int z, double explosionX, double explosionY, double explosionZ)
    {
        int meta = world.getBlockMetadata(x, y, z);
        if (meta != 1) {
            return 10.0F;
        } else if (meta == 1) {
            return 20.0F;
        }
        return blockResistance / 5.0F;
    }

Display More

Is there a way to make this more efficient. Or this is the most efficient.

GregoriusT · Feb 18th 2018

Are you really doing an "if (meta == 1) else if (meta != 1)" ? Why do you check for == and != at once? You said you know Java, but this is like the most horrific noob mistake I have seen in a while. Also the return after your if-else thing is literally Dead Code and never executed...

MrEyeballs29 · Feb 18th 2018

Did you know I renamed the localization moss stone into mossy cobblestone without a resource pack? I can be a noob all day long but at least it works okay.

GregoriusT · Feb 18th 2018

Yeah but dont claim to be knowing a language, while also causing dead code and tautologies within the same function block.

if (meta == 1) return 3.0F;

return 1.5F;

^ THAT is the proper way or if you prefer it more compact the following is great too:

return meta == 1 ? 3.0F : 1.5F;

MrEyeballs29 · Feb 18th 2018

I finally got the code correct instead of tautology code. also I changed the name moss stone into mossy cobblestone without a resource pack

Proof

Java

@Override
    public float getBlockHardness(World world, int par2, int par3, int par4)
    {
        final int meta = world.getBlockMetadata(par2, par3, par4);
        return meta == 1 ? 3.0F : 1.5F;
    }
    
    @Override
    public float getExplosionResistance(Entity par1Entity, World world, int x, int y, int z, double explosionX, double explosionY, double explosionZ)
    {
        int meta = world.getBlockMetadata(x, y, z);
        return (meta == 1 ? 60.0F : 30.0F) / 5.0F;
    }

Display More

MrEyeballs29 · Mar 10th 2018

Alight I am back again for this. How do you set the item to stay into the crafting table without returning back into your inventory.

Chocohead · Mar 11th 2018

You give it a container item so when it is used in a recipe that will be left in the crafting table.

MrEyeballs29 · Mar 11th 2018

wait the code says

Java

package mreyeballs29.decoblocks.item;
import mreyeballs29.decoblocks.Constants;
import net.minecraft.item.Item;
public class Hammer extends Item {
    public Hammer(String name) {
        this.setUnlocalizedName(name);
        this.setTextureName(Constants.TEXTURE_PREFIX + name);
        this.setContainerItem(this);
    }
}

and that still means it goes back into my inventory

Aroma1997 · Mar 11th 2018

You might need to override doesContainerItemLeaveCraftingGrid()

MrEyeballs29 · Mar 22nd 2018

Quote from GregoriusT

Try to always avoid using Enums, its not worth the effort.

If I am adding a tool. I have to forced to use an enum.

Chocohead · Mar 22nd 2018

Enums have their place, trying to totally avoid them is not going to necessarily result in the best code.

Decoblocks Modding Issues

Proof

Share

Similar Threads

[GregTech-5][1.7.10-FORGE-1355+][Unofficial but approved Port][Stable] Even GT5 Experimental is slowly getting stable.

why gregtech went from being the best mod in minecraft to a complete mess

mcmod.info Not Working

[GregTech-6][1.7.10] Moved to Website [Closed]

Users Viewing This Thread