[WIP|1.7.10] FastCraft 1.25 (Note: All Posts of new Members need to be approved first, so if you press the submit button but no new post appears here, it is in the folder of posts to be approved first, and Player will receive them a few hours later)

GregoriusT · May 1, 2015 at 2:41 PM Official Post

I have my own "Sub-OreDictionary-Thingy" in GT (ItemStack -> Data). I use getOres almost only to register Recipes with the good old OreDict Crafting Recipes in order to be NEI and CraftGuide compatible without effort or additional Handlers. I know ID+Meta -> Data doesn't allow multiple Entries per Stack, but if I only allow Material based Registrations to have Data, it is enough to work efficiently and to be able to recycle almost every Item without exploits or recursive Recipe scanning algorithms. If the OreDict needs something, then it is a "ItemStack->List of Strings"-Map for faster checks.

KingLemming · May 1, 2015 at 2:53 PM

Quote from GregoriusT

I have my own "Sub-OreDictionary-Thingy" in GT (ItemStack -> Data). I use getOres almost only to register Recipes with the good old OreDict Crafting Recipes in order to be NEI and CraftGuide compatible without effort or additional Handlers. I know ID+Meta -> Data doesn't allow multiple Entries per Stack, but if I only allow Material based Registrations to have Data, it is enough to work efficiently and to be able to recycle almost every Item without exploits or recursive Recipe scanning algorithms. If the OreDict needs something, then it is a "ItemStack->List of Strings"-Map for faster checks.

Yup, that's exactly what we do in our mirror of it:

https://github.com/CoFH/CoFHCore/…aryArbiter.java

Tsyklop · May 2, 2015 at 4:47 AM

Fix pls. CoFHTweaks

Display Spoiler

Description: Unexpected error

java.lang.IllegalArgumentException: Duplicate entries not allowed
at cofh.repack.cofh.lib.util.LinkedHashList.set(LinkedHashList.java:116)
at fastcraft.a.o.a(F:126)
at fastcraft.Hooks.t(F:147)
at net.minecraft.client.renderer.EntityRenderer.func_78471_a(EntityRenderer.java:1187)
at net.minecraft.client.renderer.EntityRenderer.func_78480_b(EntityRenderer.java:1015)
at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:989)
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:887)
at net.minecraft.client.main.Main.main(SourceFile:148)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Stacktrace:
at cofh.repack.cofh.lib.util.LinkedHashList.set(LinkedHashList.java:116)
at fastcraft.a.o.a(F:126)
at fastcraft.Hooks.t(F:147)
at net.minecraft.client.renderer.EntityRenderer.func_78471_a(EntityRenderer.java:1187)

https://twitter.com/TeamCoFH

gopwro · May 2, 2015 at 6:48 PM

I'm getting crashes lately...dunno why...

http://hastebin.com/anelofolij.1c

tethlah · May 3, 2015 at 12:59 PM

As per FTB Policy, I am intending on using Fastcraft in a modpack, LiTCraft, that I am currently in the process of getting approved. I will ensure that Fastcraft is kept up to date within at least three weeks of the latest stable release. An announcement has been placed in the modpack description alerting players that Fastcraft is in use on the server.

Keridos · May 4, 2015 at 1:17 AM

fastcraft 1.21 crash with forge 1399: https://paste.ee/p/OBVSp

nevermind that as not fastcraft...

Player · May 5, 2015 at 9:06 AM Official Post

gopwro: Some mod is causing tile entities to be created from another thread, try running with -Dfastcraft.debug.fwel

Keridos: That looks like the issue with the sponge mixins as seem in Forgeessentials. Presumably some mod contains the mixin code, I have no idea which though.

Player · May 5, 2015 at 9:49 AM Official Post

Since it has been demonstrated that advanced culling seems to be quite effective, I've reshuffled my todo list and added my own implementation for the upcoming FastCraft version 1.22.

I went with a clean room implementation with an algorithm vaguely based on tomcc's, but a lot more complex and with plenty of my own spin. The current implementation is still a bit naive and has some room for improvement, it shows the capabilities however. From what I can tell it should be significantly better than what's in 1.8. The defaults are conservative with a highly-wip config option to move culling calculations off-thread for further performance enhancement at the cost of some visual glitches when moving or looking around.

A preview release is available at (outdated, see post below for a more recent test build).

Feedback is appreciated.

Entoarox · May 5, 2015 at 11:24 AM

I've tried the new version, but I think there might be some math errors in the culling algorithm somewhere, because if I move to far from 0,0 in any dimension other then the overworld the following happens.
Moving the camera around will at times cause the chunks to flicker into visibility, but moving the view-point even a single degree from where the chunks are visible causes them to become invisible again.

Please tell me if you need me to do anything specific to get any further details, because there are no errors shown in the log.

EDIT: A bit further testing shows that all chunks that are in positive X and positive Z are always invisible, and moving the player into any of those chunks causes ALL chunks to become invisible.

Chocohead · May 5, 2015 at 5:17 PM Official Post

Just from my testing (with Optifine too ;)) it does make swinging the camera angle around fast seem a lot more fluid like 1.8 does, and I've not seen any rendering issues, but I have only been testing with IC2 and addons. All my testing was in a negative x coordinate as well, so I'll try and see if both of them being positive does break rendering.

Bogdan-G · May 5, 2015 at 10:08 PM

Test 1.22-ctest4, Worlds Mystcraft more fast render and load
Overworld and Nether normal work.
Local modpack info:

Display Spoiler

MC 1.7.10, Forge 1400

---
Use /tp -100 64 -100 and crash game:
> crash-log
https://gist.github.com/Bogdan-G/9ed140b7bf4e098da5f2
> full fml log
https://gist.github.com/Bogdan-G/54e913cf536bb40bb283
--
restart world, and normally

Player · May 6, 2015 at 12:28 PM Official Post

I've uploaded a new version at (outdated, check later post for most recent)

Entoarox · May 6, 2015 at 5:40 PM

Just finished doing al the tests I can think of, and have not ran into any issues with the latest test version of 22, Did notice only a small (~5 fps higher, at 62fps average instead of 57fps) increase in FPS, dont know if it is because fastcraft is simply that good (possible), I've simply hit the FPS limit my PC can handle (unlikely, I managed to get 120+ fps on 1.8 ) or my CPU just doesnt like playing nice with your algorithm for some weird reason (probably, It enjoys hating things for no good reason...)

What I did notice is that I never got the "lines between blocks" effect that annoys me so greatly about 1.8, so very happy with that one!

Will continue to play with the 22 test version, so if something crops up I'll be posting an issue here ASAP

_Leguan12_ · May 6, 2015 at 5:44 PM

Speaking for the "Sky is the Limit" Team I'd like to inform you that we'll include FastCraft in our modpack
( http://www.minecraftforum.net/forums/mapping…e-limit-modpack ) (If you take the link as advertising of our modpack/don't want it here I'll remove it )
if you don't have any objections. The number of mods in the modpack makes it nearly impossible to run it on a not-quite-good PC without Fastcraft

Chocohead · May 6, 2015 at 5:51 PM Official Post

Ctest6 crashes when ever I try to load a world:

Display Spoiler

Code

---- Minecraft Crash Report ----
// I let you down. Sorry :(




Time: 06/05/15 17:49
Description: Unexpected error




java.lang.IllegalAccessError: tried to access field net.minecraft.client.renderer.RenderGlobal.field_72766_m from class fastcraft.a.o
	at fastcraft.a.o.a(F:84)
	at fastcraft.a.o.a(F:71)
	at fastcraft.c.a(F:65)
	at cpw.mods.fml.common.eventhandler.ASMEventHandler_11_c_a_Load.invoke(.dynamic)
	at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54)
	at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:138)
	at net.minecraft.client.multiplayer.ChunkProviderClient.func_73158_c(ChunkProviderClient.java:59)
	at net.minecraft.client.multiplayer.WorldClient.func_73025_a(WorldClient.java:144)
	at net.minecraft.client.network.NetHandlerPlayClient.func_147269_a(NetHandlerPlayClient.java:1185)
	at net.minecraft.network.play.server.S26PacketMapChunkBulk.func_148833_a(S26PacketMapChunkBulk.java:184)
	at net.minecraft.network.play.server.S26PacketMapChunkBulk.func_148833_a(S26PacketMapChunkBulk.java:242)
	at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:212)
	at net.minecraft.client.Minecraft.func_71407_l(Minecraft.java:2050)
	at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:962)
	at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:887)
	at net.minecraft.client.main.Main.main(SourceFile:148)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)







A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------




-- Head --
Stacktrace:
	at fastcraft.a.o.a(F:84)
	at fastcraft.a.o.a(F:71)
	at fastcraft.c.a(F:65)
	at cpw.mods.fml.common.eventhandler.ASMEventHandler_11_c_a_Load.invoke(.dynamic)
	at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54)
	at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:138)
	at net.minecraft.client.multiplayer.ChunkProviderClient.func_73158_c(ChunkProviderClient.java:59)
	at net.minecraft.client.multiplayer.WorldClient.func_73025_a(WorldClient.java:144)
	at net.minecraft.client.network.NetHandlerPlayClient.func_147269_a(NetHandlerPlayClient.java:1185)
	at net.minecraft.network.play.server.S26PacketMapChunkBulk.func_148833_a(S26PacketMapChunkBulk.java:184)
	at net.minecraft.network.play.server.S26PacketMapChunkBulk.func_148833_a(S26PacketMapChunkBulk.java:242)
	at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:212)




-- Affected level --
Details:
	Level name: MpServer
	All players: 1 total; [EntityClientPlayerMP['Chocohead'/373, l='MpServer', x=8.50, y=66.62, z=8.50]]
	Chunk stats: MultiplayerChunkCache: 1, 1
	Level seed: 0
	Level generator: ID 00 - default, ver 1. Features enabled: false
	Level generator options: 
	Level spawn location: World: (-124,64,248), Chunk: (at 4,4,8 in -8,15; contains blocks -128,0,240 to -113,255,255), Region: (-1,0; contains chunks -32,0 to -1,31, blocks -512,0,0 to -1,255,511)
	Level time: 0 game time, 0 day time
	Level dimension: 0
	Level storage version: 0x00000 - Unknown?
	Level weather: Rain time: 0 (now: false), thunder time: 0 (now: false)
	Level game mode: Game mode: creative (ID 1). Hardcore: false. Cheats: false
	Forced entities: 1 total; [EntityClientPlayerMP['Chocohead'/373, l='MpServer', x=8.50, y=66.62, z=8.50]]
	Retry entities: 0 total; []
	Server brand: fml,forge
	Server type: Integrated singleplayer server
Stacktrace:
	at net.minecraft.client.multiplayer.WorldClient.func_72914_a(WorldClient.java:373)
	at net.minecraft.client.Minecraft.func_71396_d(Minecraft.java:2433)
	at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:916)
	at net.minecraft.client.main.Main.main(SourceFile:148)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)




-- System Details --
Details:
	Minecraft Version: 1.7.10
	Operating System: Windows 8 (amd64) version 6.2
	Java Version: 1.7.0_51, Oracle Corporation
	Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
	Memory: 693130344 bytes (661 MB) / 869793792 bytes (829 MB) up to 1908932608 bytes (1820 MB)
	JVM Flags: 2 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xmx2G
	AABB Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used
	IntCache: cache: 0, tcache: 0, allocated: 12, tallocated: 94
	FML: MCP v9.05 FML v7.10.85.1272 Minecraft Forge 10.13.2.1272 Optifine OptiFine_1.7.10_HD_U_B5 10 mods loaded, 10 mods active
	mcp{9.05} [Minecraft Coder Pack] (minecraft.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
	FML{7.10.85.1272} [Forge Mod Loader] (forge-1.7.10-10.13.2.1272.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
	Forge{10.13.2.1272} [Minecraft Forge] (forge-1.7.10-10.13.2.1272.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
	CodeChickenCore{1.0.4.29} [CodeChicken Core] (minecraft.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
	NotEnoughItems{1.0.3.77} [Not Enough Items] (NotEnoughItems-1.7.10-1.0.3.77-universal.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
	FastCraft{1.22} [FastCraft] (fastcraft-1.22-ctest6.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
	IC2BackpackHUD{3.0} [IC2 Backpack HUD] (IC2 Backpack HUD v3.0 - MC 1.7.10.zip) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
	IC2{2.2.718-experimental} [IndustrialCraft 2] (industrialcraft-2-2.2.718-experimental.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
	ihl{0.546} [IHL Tools & Machines for IC2V2] (ihl-tools_n_machines-0.546-1.7.10.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
	MineTweaker3{3.0.9B} [MineTweaker 3] (MineTweaker3-1.7.10-3.0.9C.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
	Launched Version: 1.7.10-Forge10.13.2.1272
	LWJGL: 2.9.1
	OpenGL: Intel(R) HD Graphics 4400 GL version 4.3.0 - Build 10.18.10.3960, Intel
	GL Caps: Using GL 1.3 multitexturing.
Using framebuffer objects because OpenGL 3.0 is supported and separate blending is supported.
Anisotropic filtering is supported and maximum anisotropy is 16.
Shaders are available because OpenGL 2.1 is supported.




	Is Modded: Definitely; Client brand changed to 'fml,forge'
	Type: Client (map_client.txt)
	Resource Packs: []
	Current Language: English (US)
	Profiler Position: N/A (disabled)
	Vec3 Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used
	Anisotropic Filtering: Off (1)

Display More

EeveeA_ · May 6, 2015 at 11:29 PM

My first post, not sure if optifine is taboo here, but most people still add it to their packs after downloading, so I figure it's a valid reason to post a crash report.

Crash Report , FastCraft Version 1.22-ctest6

Tl;Dr - Optifine 1.7.10 HD B7 is crashing the latest version of fastcraft

cindylo · May 7, 2015 at 12:38 AM

Two questions for you Player. A is there any planned compatibility between fastcraft and CoFHTweaks? And B can we get a peak at your code/why is it obfuscated?

EeveeA_ · May 7, 2015 at 1:02 AM

My mistake, I was not paying attention that replies have to be approved, thought it was something I was doing wrong and attempted to re-post my reply multiple times.

Player · May 7, 2015 at 9:23 AM Official Post

The culling tweak only works without Optifine.

Bogdan-G: That's not a FastCraft issue as far as I'm aware, something is corrupting the biome decorator state.

Entoarox: Try also comparing the value after C: in the F3 screen between FC 1.21 and FC 1.22. You need a normal (non-flat/void) world, not use Optifine and VSync (implicit/explicit) disabled to see a difference I assume. Bugs may be another cause.

Chocohead/EeveeA_: It's a temporary incompatibility with Optifine, it'll be restored in the next build. As mentioned above the major change isn't active with Optifine.

cindylo: Currently it doesn't look like they are willing to provide the means to make it compatible in a reasonable fashion as I've requested in their issue tracker. I've outlined the reasoning behind obfuscation at [WIP|1.7.10] FastCraft 1.21 besides being able to strip all the wip code for new features.

cindylo · May 7, 2015 at 4:45 PM

Ok I understand that completely, granted I do think there could be a better way but that's just my opinion. Also do you have a handy link to that issue around? Unless it was deleted(wouldn't surprise me) I can't seem to find it.

Users Viewing This Thread