[GregTech-5][1.7.10-FORGE-1355+][Unofficial but approved Port][Stable] Even GT5 Experimental is slowly getting stable.

Blood Asp · Jun 11th 2015

Quote from chloe

Still having issues with Large Turbines. They can only be built when the Control Block is on the North or East Side (facing)... but will not work when built on the South or West Sides. Using version 19.

I thought i fixed it. While testing, before 3 directions were fine, 1 failed. Then i fixed the one not working direction. I did not test if the other directions still work, so i might have broken the others while fixing the one.

Quote from sprAngles

Gregtech - 5.08.19
Galacticraft - 3.0.11.306
Forge - 10.13.3.1388

Oxygen works fine in input hatch, as long as you use GT's version.

Oh sorry but asking again, do fusion recipes get overclocked if it's at a higher voltage than the specified recipe?

I use Galacticraft and GT5.08.19 together on one server and have no issues. Electrolyzer produces GT Oxygen from water and that works just fine in Blast furnace.

The Fusion Reactor acually does overclock. It even does it without loosing efficiency. 1 tier higher = 2xspeed,2xenergy used.

Quote from leagris

Blood-Asp, did you break change something in build .19 that could cause GT Centrifuges to no longer process Forestry products (combs, propolis,... ?)

I did not touch anything i think that might cause this problem. Will look into it.

INVICTRA · Jun 11th 2015

This thing rly bothers me:

- Charged Certus Quartz Crystal can't be Macerated

- Charged Certus Quartz Dust can be obtained from processing Certus Quartz Ore or Quartzite Ore

The annoying thing is that I got a ton of Charged Certus Quartz Dust as a byproduct but can't turn it into Charged Certus Quartz Crystal. I think the Autocalve should convert them.

laurynasl · Jun 11th 2015

I tried Galacticraft 306. Electrolyzer shows that it contains GT oxygen, it tries to output to input hatch, but it happily refuses. I have a feature request. Take a line:
https://github.com/Blood-Asp/G…tity_Hatch_Input.java#L64

and do something like return true if config says so. That should work.

Blood Asp · Jun 11th 2015

That line of code makes sense and should not be disabled. I would prefer to find the real reason it fails only for you. Can you make some screenshots? Showing the whole setup and the fluids?

GregoriusT · Jun 11th 2015

That Line only refuses to let the Fluid in if there is no Recipe using said Fluid. So even if it were able to enter the Machine, the Recipe would not process.

And if you happen to be piping the Stuff into the Hatch from a Side which is not the dedicated Input Side then this is your Problem, because Hatches only accept from one Side ONLY.

laurynasl · Jun 11th 2015

After removing galacticraft, input hatch accepts oxygen (that is, blast furnace works perfectly).

That line of code: return mRecipeMap == null || mRecipeMap.containsInput(aFluid);

part 1: mRecipeMap == null
Is true when chunk is very recently loaded. Not very interesting.

part 2: mRecipeMap.containsInput(aFluid)
calls: https://github.com/Blood-Asp/G…/util/GT_Recipe.java#L221
then: https://github.com/Blood-Asp/G…/util/GT_Recipe.java#L226

last line: return aFluid != null && mRecipeFluidMap.containsKey(aFluid);
where mRecipeFluidMap is public final Map<Fluid, Collection<GT_Recipe>> mRecipeFluidMap = new HashMap<Fluid, Collection<GT_Recipe>>();

So there is a map with a key of class Fluid (from forge). When keys are equal for containsKey() method?
I didn't find this specified for HashMap, but for Map it is: [size=10](key==null ? k==null : key.equals(k)) http://docs.oracle.com/javase/…Key%28java.lang.Object%29
Does forge Fluid implement equals() or hashCode()? No: https://github.com/MinecraftFo…ftforge/fluids/Fluid.java
Then equality implementation of Object is used. Which may be comparison of internal addresses (pointers?) of objects. Oracle java documentation about that: http://docs.oracle.com/javase/…bject.html#hashCode%28%29

What happens, when there are multiple oxygens, and only one is in a hash mRecipeFluidMap? Only that one will be accepted.
I don't know what exactly happens, but:
without galacticraft - everything works
with galacticraft - right after chunk load some oxygen (like 5000 liters) is accepted to input hatch (because mRecipeMap == null). After that, no oxygen is accepted. My base is far from world spawn, so chunk actually unloads/loads when I reconnect to server or switch dimensions. Oxygen in electrolyzer's output looks like the same GT oxygen, but that is just a visual, so might be disguised galacticraft's oxygen.

Drawfox · Jun 11th 2015

Quote from laurynasl

I tried Galacticraft 306. Electrolyzer shows that it contains GT oxygen, it tries to output to input hatch, but it happily refuses. I have a feature request. Take a line:
https://github.com/Blood-Asp/G…tity_Hatch_Input.java#L64

and do something like return true if config says so. That should work.

Electrolyzing water gives Oxygen cells and Hydrogen as Fluid, right?
I didn't knew that the input hatch accepted automatically outputted cells, does it?
If so, it will make my life so much easier, why didn't I thought about that before?

MauveCloud · Jun 11th 2015

I found a small issue with the "Real Luck" achievement: it didn't show up when I transferred the Zero Point Module from the chest to my inventory; I had to drop it on the ground and pick it up to get the achievement.

GregoriusT · Jun 11th 2015

Quote from laurynasl

After removing galacticraft, input hatch accepts oxygen (that is, blast furnace works perfectly).

That line of code: return mRecipeMap == null || mRecipeMap.containsInput(aFluid);

part 1: mRecipeMap == null
Is true when chunk is very recently loaded. Not very interesting.

part 2: mRecipeMap.containsInput(aFluid)
calls: https://github.com/Blood-Asp/G…/util/GT_Recipe.java#L221
then: https://github.com/Blood-Asp/G…/util/GT_Recipe.java#L226

last line: return aFluid != null && mRecipeFluidMap.containsKey(aFluid);
where mRecipeFluidMap is public final Map> mRecipeFluidMap = new HashMap>();

So there is a map with a key of class Fluid (from forge). When keys are equal for containsKey() method?
I didn't find this specified for HashMap, but for Map it is: (key==null ? k==null : key.equals(k)) http://docs.oracle.com/javase/…Key%28java.lang.Object%29
Does forge Fluid implement equals() or hashCode()? No: https://github.com/MinecraftFo…ftforge/fluids/Fluid.java
Then equality implementation of Object is used. Which may be comparison of internal addresses (pointers?) of objects. Oracle java documentation about that: http://docs.oracle.com/javase/…bject.html#hashCode%28%29

What happens, when there are multiple oxygens, and only one is in a hash mRecipeFluidMap? Only that one will be accepted.
I don't know what exactly happens, but:
without galacticraft - everything works
with galacticraft - right after chunk load some oxygen (like 5000 liters) is accepted to input hatch (because mRecipeMap == null). After that, no oxygen is accepted. My base is far from world spawn, so chunk actually unloads/loads when I reconnect to server or switch dimensions. Oxygen in electrolyzer's output looks like the same GT oxygen, but that is just a visual, so might be disguised galacticraft's oxygen.

Display More

The thing is that there are NO EQUAL Fluids with Forge, meaning a simple == Check is all it needs to check if a Fluid is the right one (and equals is not implemented in Fluids because there are no equal Fluids, anything else would break Forge itself). If GT Oxygen and GC Oxygen happen to share the same Fluid Name (and they do share it) then the one added later will not exist at all, because Forge doesn't allow that. Either GT Oxygen exists or GC Oxygen exists, but both cannot exist at the same time, meaning GC Oxygen cannot disguise as GT Oxygen and also not vice versa.

And even if that so called broken Oxygen enters, the Recipes will not accept those like 5000 Liters of it, meaning they are stuck in there forever being unused.

The only Bug here is that it accepts things when the RecipeMap is null. Maybe that should be changed to not let anything in when that Map is null. Maybe GC does something to the Fluid Registry that breaks Forge Fluids as a whole and that is the actual Problem.

leagris · Jun 11th 2015

Did you had a chance to look at what cause the recipes for Forestry product not being registered for centrifuges?

Reference: GT5U Issue #49

Forestry centrifuges recipes where changed around builds 500 501.

There is now Improve the probability system for centrifuge outputs
https://github.com/ForestryMC/…d41fd2eac106e1753b6d85ca0

This is likely what broke forestry centrifuge recipes in GregTech centrifuges.
If you are able to fix it Blood, it'd be awesome.

SteamT · Jun 11th 2015

In regards to your modding guide, will the "Basic Functions of the GT API" chapter be fleshed out soon, or am I better off figuring out the GT API by myself?

Sapient · Jun 11th 2015

Blood Asp, do u plan to add to GT cables ability to connect IC power sources? In case of disabling IC cables at all, what should i do? Make pair of transformers to each Nuclear reactor / Kinetic generator?

Blood Asp · Jun 11th 2015

Quote from leagris

This is likely what broke forestry centrifuge recipes in GregTech centrifuges.
If you are able to fix it Blood, it'd be awesome.

I hope the next weekend is long enough so i can work trough the issues.

Quote from SteamT

In regards to your modding guide, will the "Basic Functions of the GT API" chapter be fleshed out soon, or am I better off figuring out the GT API by myself?

I plan on doing that quite soon. Just allways new GT5U issues before i get to there.

Quote from Sapient

Blood Asp, do u plan to add to GT cables ability to connect IC power sources? In case of disabling IC cables at all, what should i do? Make pair of transformers to each Nuclear reactor / Kinetic generator?

No, IC2 power sources connecting with cables is not possible. You allways must place a GT Transformer next to the powersource and that will not change.

Sapient · Jun 11th 2015

Quote from Blood Asp

No, IC2 power sources connecting with cables is not possible. You allways must place a GT Transformer next to the powersource and that will not change.

Ok. Is there any chance Battery buffers will accept IC power?

Blood Asp · Jun 11th 2015

Well, that is at last possible code wise.

Crowded Bear · Jun 11th 2015

Hmm...negative durability :-?

I want to say I was really tempted not to report this :evil:

Blood Asp · Jun 12th 2015

This one of the Moments: "Damn, i knew i forgot something."

Well, the turbines still take too much damage anyways, so for now it is fine.

leagris · Jun 12th 2015

Quote from Blood Asp

This one of the Moments: "Damn, i knew i forgot something."

Well, the turbines still take too much damage anyways, so for now it is fine.

And the Tooltip mentioning Optimal Steam flow, is cosmetically disturbing when in non-steam generator.
Maby just "Optimal flow" would be better, though, I doubt flow requirements are the same for plasma, natural gas, hydrogen, methane or steam.

SvEgiiVEteR · Jun 12th 2015

When install gregtech_1.7.10-5.08.19.jar can not go to the server.
no gregtech mod I can go.
forg 1448
IC 2-2.2.736-experimental
servre log
http://paste.ubuntu.com/11702427/
client log
http://paste.ubuntu.com/11702429/
Crash Report
http://paste.ubuntu.com/11702439/
client crash. the server does not break.

https://github.com/Blood-Asp/GT5-Unofficial/issues/45
I found, like my mistake.

AnikiLulala · Jun 12th 2015

HI Blood asp, thanks for the amazing work!

I found that there`s might be a bug involving the fusion reactor and the new achievement system.
If the option EnableAchievements = false, the fusion reactor will work in a strange state.
Or if do not disable the achievements system, the server side will receive message spams.

More details I have posted on the bugreports on Github
https://github.com/Blood-Asp/GT5-Unofficial/issues/46

[GregTech-5][1.7.10-FORGE-1355+][Unofficial but approved Port][Stable] Even GT5 Experimental is slowly getting stable.

Share

Users Viewing This Thread