[IC2 Exp | 1.12.2] IC2Guns addon

trexxet · February 20, 2019 at 12:25 PM

Do you like shooting that mobs with your Mining Laser?
Do you hate fixing your structures after a miss?

Then it's for you! A good ol' rifle that wipes mobs out and keeps your landscape safe.

Github

[TO BE UPDATED]

trexxet · February 20, 2019 at 12:33 PM

I'm facing an issue with canning machine recipe:

Code

NBTTagCompound fullMagazineNBT = ItemMagazine.getNBTForAmmo(ItemMagazine.MAX_AMMO);
addCanningRecipe(input.forExactStack(new ItemStack(magazine, 1, 0, emptyMagazineNBT)),
                input.forStack(new ItemStack(cartridge, 20)),
                new ItemStack(magazine, 1, 0, fullMagazineNBT));
...
public static NBTTagCompound getNBTForAmmo (int value) {
        NBTTagCompound nbt = new NBTTagCompound();
        nbt.setInteger(AMMO_KEY, value);
        return nbt;
    }
...
private static void addCanningRecipe (IRecipeInput container, IRecipeInput filler, ItemStack out) {
        Recipes.cannerBottle.addRecipe(container, filler, out, false);
    }

Display More

Debugger shows that addCanningRecipe gets output item stack with NBT ammo MAX_AMMO = 20, however, this recipe produces a magazine with NBT ammo 0. Is it an API bug, or am I doing it the wrong way?

By the way, I'm totally not a Java programmer, so beware of ugly code.

Chocohead · February 20, 2019 at 12:51 PM Official Post

An addon style we've not seen in a long time, looking forward to see how it turns out.

As for your NBT issue, the ItemStack constructor is a little misleading in that whilst it takes in an NBTTagCompound, that's only for Forge's capabilities and not the ItemStack's own NBT. You'll want to do something like

Java

addCanningRecipe(input.forExactStack(makeMagazine(0)),
                 input.forStack(new ItemStack(cartridge, 20)),
                 makeMagazine(ItemMagazine.MAX_AMMO);
...
private static ItemStack makeMagazine(int ammo) {
    ItemStack magazine = new ItemStack(magazine);
    magazine.setTagCompound(ItemMagazine.getNBTForAmmo(ammo));
    return magazine;
}

That way the NBT is properly set for the ItemStack (using setTagCompound).

Dogger · February 20, 2019 at 10:38 PM

Hey, can someone attach a compiled version of this mod to this thread? I tried compiling it myself and either there's something wrong or I'm too dum dum to compile it myself, thanks.

SM84CE · February 21, 2019 at 1:11 AM

try downloading the repo, run gradlew setupDecompWorkspace, and after that finishes, try gradlew build. the built mod should be in built/libs. Thats for Windows, idk about the other OS's though...

I don't think that gradlew eclipse is needed before building...

Dogger · February 21, 2019 at 11:55 AM

Quote from SM84CE

try downloading the repo, run gradlew setupDecompWorkspace, and after that finishes, try gradlew build. the built mod should be in built/libs. Thats for Windows, idk about the other OS's though...

I don't think that gradlew eclipse is needed before building...

Well yes, I did those steps, this time I tried it on another CLI tool and not powershell, and it.. worked?

Dogger · February 21, 2019 at 11:55 AM

Also how do you load a magazine into the rifle, can't seem to do anything with the rifle even after filling a few magazines and having them in my inv, etc.

Chocohead · February 21, 2019 at 1:02 PM Official Post

The rifle doesn't seem to be finished yet, it's just an item which doesn't stack at the moment.

trexxet · February 21, 2019 at 1:05 PM

Quote from Dogger

Also how do you load a magazine into the rifle, can't seem to do anything with the rifle even after filling a few magazines and having them in my inv, etc.

It's not finished, I've been working on it only for 4 days. I'm going to finish it in a week.

Dogger · February 21, 2019 at 1:10 PM

Alright, thanks.

Dogger · February 21, 2019 at 1:18 PM

Also, when starting my forge server with the mod I got this crash:

https://hastebin.com/feqobeyegi.rb

Hope that helps if you're planning to make this multiplayer compatible in the future.

trexxet · February 21, 2019 at 1:45 PM

Quote from Dogger

Hope that helps if you're planning to make this multiplayer compatible in the future.

Of course.

Quote from Dogger

I got this crash

Thx, seems like localization is client side only.

Kane Hart · February 21, 2019 at 10:06 PM

This is such a great idea. If you polish this and give some decent configure options via the configs I be happy to add this to my pack. I'm making a pack with mostly IC2 / TR mixed in and NO Tinkers. I think this would do wonders

Kazifilan36 · October 23, 2019 at 6:04 AM

This mod idea does carry such possibilities and oportunities. Would love to see something other than ICBM or Flans mods (nothing personal JambioFlan! loved your mod since 2010).

Sekator · August 9, 2020 at 8:21 PM

Is this dead? The Github link from the first post is broken.

This addon idea is one thing Industrialcraft was always lacking, so would love to see this completed.

trexxet · September 1, 2020 at 11:52 PM

Quote from Sekator

Is this dead? The Github link from the first post is broken.

This addon idea is one thing Industrialcraft was always lacking, so would love to see this completed.

Yep, I got overcringed by Forge mess (and Java, hecking hate it), so I just gave this up. Sorry.

Here is source code (Idea project) for what I currently have. You can freely use it, try to finish this addon or even integrate it in IC.